-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dprint formatter #6
Conversation
Thanks for the pr! Would you mind writing a test for this pr and the other two linter ones? It's easier for someone that uses the tool to test locally and it ensures that everything is working correctly :) Of course if you don't want to spend more time on this just poke me and I will still happily merge this. |
I looked at adding tests but the CI runs need approval and there don't seem to be any instructions on how to run tests locally. I don't mind writing some tests but I don't want to spend a lot of time figuring out set up in order to do that. I can probably provide some tests that are pretty close if you want to take it over (already in this PR in a reverted commit). |
luarocks --lua-version=5.1 install vusted For formatter show the input and expected formatted output (what you did was the right thing, but since you tested with tsx maybe write a tsx snippet and not just js?), and for linters the input and the expected diagnostics (get that by running |
This reverts commit 67bfbab.
I think you should also include a |
Good call, I added |
Any blockers I can address here? |
No description provided.